[MERGE] Use the new progress reporting bzrlib API
v.ladeuil+lp at free.fr
Fri Jun 12 16:56:18 BST 2009
>>>>> "Jelmer" == Jelmer Vernooij <jelmer at samba.org> writes:
Jelmer> I think you may also be able to reproduce it
Jelmer> e.g. when annotating files in the openoffice.org
Jelmer> I can't reproduce it with your latest patch anymore,
Jelmer> but I'm sure I got a single line of output with
Jelmer> activity reports earlier.
Some revision interpretation needing to occur before the bzr-gtk
command is even started may be ?
No way to address that then :-/
Jelmer> _progress_all_finished shouldn't reset the progress
Jelmer> bar widget to None; if the window triggers more
Jelmer> progress reports, we shouldn't be displaying those in
Jelmer> a window. To reproduce, try hitting "Refresh" in the
Jelmer> viz window.
Right, reproduced, but given that stdout mentions many other
problems, I think we'd better fix them in another patch :-)
And I think the right fix here is to re-install the progress
widget when the refresh button is clicked.
There is still an inherent weakness in the current design
(already present in the last one, may be worse even): if you
create a bzr-gtk window with progress widget from a bzr-gtk
window with a progress widget, which one should show the
Jelmer> Other than this, this patch seems good enough to
Jelmer> land. We can always fix the minor issues later, right
Jelmer> now this not landing breaks bzr-gtk in general.
Exactly and it seems that several users were already blocked.
So I landed the patch as is.
More information about the bzr-gtk