[MERGE] Add signatures tab to revisionview

Jelmer Vernooij jelmer at samba.org
Mon Mar 31 16:25:42 BST 2008


On Mo, 2008-03-31 at 17:19 +0200, Daniel Schierbeck wrote:
> On Mon, 2008-03-31 at 16:17 +0200, Jelmer Vernooij wrote:
> > On So, 2008-03-30 at 19:10 +0200, Daniel Schierbeck wrote:
> > > On Sun, 2008-03-30 at 18:07 +0200, Jelmer Vernooij wrote:
> > > > This adds the signature tab that Daniel added with two minor cleanups -
> > > > to allow using it if gpg is not installed and to find installed icons.
> > > I actually think it will still throw an error if gpg is not installed on
> > > the system, as the gpg wrapper used just calls the executable. We can
> > > merge it, but it'll require further improvements before it can be
> > > released.
> > Ahh, that's true. I hadn't seen you had imported the gpg module. Yeah,
> >  it doesn't make an awful lot of sense now, so I guess we'll have to
> >  add another check. 

> Ideally we could find a *real* GPG library, though I didn't really have
> that much luck last time. How about using Seahorse? That would
> introduce a new dependency, but it could be optional.
I'd be happy to rely on Seahorse if it's optional. The nice thing about
seahorse would also be that it should be able to give us GTK+ dialogs
for signing revisions rather than prompting on the (not visible to the
user) console.

Cheers,

Jelmer
-- 
Jelmer Vernooij <jelmer at samba.org> - http://samba.org/~jelmer/
Jabber: jelmer at jabber.fsfe.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 307 bytes
Desc: This is a digitally signed message part
Url : https://lists.canonical.com/archives/bzr-gtk/attachments/20080331/69df6a97/attachment.pgp 


More information about the bzr-gtk mailing list