[MERGE] Fix test failing after a feature rename in bzr.

Vincent Ladeuil v.ladeuil+lp at free.fr
Tue Jun 10 07:50:59 BST 2008


>>>>> "john" == John Arbash Meinel <john at arbash-meinel.com> writes:

    john> Vincent Ladeuil wrote:
    >> A recent modification in bzr core made the gtk test suite failed (3 tests).
    >> 
    >> This patche fixes two of them.
    >> 
    >> Vincent
    >> 
    >> 

    john> BB:approve  (I don't actually have approval rights)

    john> though you may want to optionally search for the object
    john> in multiple places, with a 'getattr' test. But I may be
    john> one of the few that actually writes plugins to be
    john> compatible with *older* versions of bzr.

I thought about it, but as it seems that only few people run the
bzr-gtk test suite it would:
- be a waste,
- make the tests harder to read and to maintain

 :-/

If you're wondering why *I* do, it's because adding test servers
via a plugin make it impossible to use --no-plugins :-)

But since you popped out, can you have a look at the remaining
failing test, I have the feeling it will be obvious for you or
that a least you could shed some light:

FAIL: bzrlib.plugins.gtk.tests.test_commit.TestPendingRevisions.test_pending_revisions_multi_merge
    not equal:
a = ['vila at vilabuntu-20080609155304-xzyt8ztzsa0gv60z',
 'vila at vilabuntu-20080609155304-ak4nso8z42jxw4x9',
 'vila at vilabuntu-20080609155304-79zr2r7b0ok9336x']
b = ['vila at vilabuntu-20080609155304-xzyt8ztzsa0gv60z',
 'vila at vilabuntu-20080609155304-79zr2r7b0ok9336x']

  Vincent



More information about the bzr-gtk mailing list