[MERGE] Lots of improvements

Jelmer Vernooij jelmer at samba.org
Wed Nov 28 18:08:52 GMT 2007


Am Mittwoch, den 28.11.2007, 15:29 +0100 schrieb Daniel Schierbeck:
> On Tue, 2007-11-27 at 23:00 +0100, Jelmer Vernooij wrote:
> > Am Dienstag, den 27.11.2007, 22:33 +0100 schrieb Daniel Schierbeck:
> > > On Tue, 2007-11-27 at 13:56 +0100, Szilveszter Farkas wrote:
> > > > This request doesn't seem to be picked up by Bundle Buggy, so I'm
> > > > replying here...
> > > > 
> > > > First I'd like to apologize that it took so long to review this merge
> > > > request, but university is getting tough these weeks for me.
> > > > 
> > > > > It adds a menubar, improved usability of the back and forward buttons,
> > > > > and some refactoring.
> > > > 
> > > > It looks really great, but I still have 2 minor concerns:
> > > > 
> > > > 1) Showing both Close and Exit buttons doesn't feel okay (for me at
> > > > least). I think it should display either Exit (if no parent window
> > > > specified, that means 'bzr viz' was called) or Close (if there is a
> > > > parent window, e.g. Olive).
> > > > 
> > > > 2) In the Edit menu Branch Settings and Settings are confusing as well.
> > > > The latter should be either Global Settings or Bazaar Settings IMHO.
> > > > 
> > > > Apart from these little things, I support the merge request.
> > > 
> > > Great! I've fixed both issues, and pushed the branch to lp.
> > This change seems wrong to me:
> > 
> >      default_encoding = sys.getdefaultencoding()
> >      try:
> >          result = TestSuite()
> > +        try:
> > +            import_pygtk()
> > +        except errors.BzrCommandError:
> > +            return result
> >          result.addTest(tests.test_suite())
> >      finally:
> >          if sys.getdefaultencoding() != default_encoding:
> > 
> > Why would you want to catch BzrCommandError there?
> 
> That change was by Aaron Bentley, and was committed to trunk. I just
> merged in trunk and got it, so I have no knowledge of how it works. The
> commit message is "Allow test suite to run without pygtk".
Whoops, sorry. I'll take it up with Aaron then. 

bb:approve

Cheers,

Jelmer

-- 
Jelmer Vernooij <jelmer at samba.org> - http://samba.org/~jelmer/
Jabber: jelmer at jabber.fsfe.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 307 bytes
Desc: Dies ist ein digital signierter Nachrichtenteil
Url : https://lists.canonical.com/archives/bzr-gtk/attachments/20071128/36458670/attachment.pgp 


More information about the bzr-gtk mailing list